Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndarray: change internal api of plus to help autograd #364

Merged
merged 1 commit into from
Dec 9, 2017

Conversation

iblislin
Copy link
Member

@iblislin iblislin commented Dec 7, 2017

address #274 (comment)

@codecov-io
Copy link

codecov-io commented Dec 7, 2017

Codecov Report

Merging #364 into master will not change coverage.
The diff coverage is 92.3%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #364   +/-   ##
=======================================
  Coverage   70.28%   70.28%           
=======================================
  Files          24       24           
  Lines        1942     1942           
=======================================
  Hits         1365     1365           
  Misses        577      577
Impacted Files Coverage Δ
src/ndarray.jl 86.19% <92.3%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d4f62...a009708. Read the comment docs.

@pluskid pluskid merged commit 233fcfc into master Dec 9, 2017
@iblislin iblislin deleted the ib/nd-ad-plus branch December 9, 2017 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants